search

OpenDroneMap / posm-gcpi

Ground Control Point interface (GCPi) for OpenDroneMap
15 stars 8 forks source link

Don't allow users to associate one-to-many GCPs #30

Closed pierotofy closed 6 years ago

pierotofy commented 6 years ago

I don't think this is a bug per se, but I can associate the same GCP in an image to multiple GCPs in the map.

image

EPSG:4326
-90.74 57.35 0 3587.54 797.25 DJI_0018.JPG -94.96 22.33 0 3653.54 1075.25 DJI_0018.JPG -120.27 62.45 0 3653.54 1075.25 DJI_0018.JPG

smathermather commented 6 years ago

Hmm, it's a many-to-many rather than a many-to-one. That could be a logical problem... .

smathermather commented 6 years ago

@pierotofy -- can you verify this is resolved in the latest updates?

pierotofy commented 6 years ago

Still there as of latest master.

ebrelsford commented 6 years ago

@pierotofy Thanks for checking, but I'm having a hard time replicating this issue now and I believe it is fixed. Would you mind checking the latest master, rebuilding, and testing again?

To be clear, I'm starting with these two points associated with each other:

selection_003

then I draw a new point on the map and click on the image point, and the image point is only associated with that point on the map:

selection_005

Am I misunderstanding the issue you're seeing? Or can you send instructions for replicating it? Thanks!

pierotofy commented 6 years ago

Seems to work quite a bit better as of latest master (the problem seems to be gone when binding from multiple map GCPs to a single image GCP).

I still found a way to bind two image GCPs to one map GCP.

  1. Load image
  2. Place 2 GCPs on the image
  3. Place 1 GCP on the map
  4. Click first image GCP, bind to GCP on map.
  5. Click second image GCP, bind to GCP on map.

Press export:

+proj=utm +zone=11 +ellps=WGS84 +datum=WGS84 +units=m +no_defs  
543985.61   6227686.70  0   604.00  318.17  image.png
543985.61   6227686.70  0   608.00  190.17  image.png

Same lat/lon values, different imageX/imageY coordinates. Not a big problem, if time is better spent elsewhere I'd say don't worry about it.

ebrelsford commented 6 years ago

Okay, that's helpful because I was only testing to ensure that an image point can only be associated with one map point, not the other way around.

I imagine there are situations where we might want multiple image points to be associated with the same map point, correct? For example, where there are two images of the same GCP.

smathermather commented 6 years ago

Correct — multiple images can be associated with the same GCP.

Stephen V. Mather +1 (216) 339-6347 (Signal, Telegram, Cell, and WhatsApp)

On Mar 23, 2018, at 10:13, Eric Brelsford notifications@github.com wrote:

Okay, that's helpful because I was only testing to ensure that an image point can only be associated with one map point, not the other way around.

I imagine there are situations where we might want multiple image points to be associated with the same map point, correct? For example, where there are two images of the same GCP.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.