search

OpenELEC / service.openelec.settings

service.openelec.settings - OpenELEC settings addon
Other
12 stars 35 forks source link

Network dialog not working in addon when field is blank (Master build) #48

Closed MilhouseVH closed 10 years ago

MilhouseVH commented 10 years ago

It looks like this XBMC Helix commit from @jmarshallnz has changed (or possibly broken) the behaviour of the network dialog when dealing with initially blank fields.

See forum discussion here and preceding posts (with screenshots).

Not sure if this problem needs to be fixed in the OpenELEC Settings addon (with a non-blank default field?) or if an additional fix is required in XBMC to correct the problem introduced by the above change.

Chances are this change affects more than just this addon, but I don't have any other examples to prove that - for instance, the SMB Client -> WINS server field is unaffected as the default field value is 0.0.0.0, not blank.

I'm raising this issue so that it can be addressed one way or the other, please close if decided the addon is not the right place for the fix.

To reproduce:

  1. Disable DHCP on the LAN
  2. Reboot device that has until now been using DHCP for address assignment
  3. Open OpenELEC Settings addon and assign a manual/static IP address
  4. The Gateway address will be blank and you will be unable to open the IP address dialog. The DNS address fields will be affected in the same way.
MilhouseVH commented 10 years ago

Thanks @jmarshallnz, closing this bug as resolved following the merge of commit https://github.com/xbmc/xbmc/commit/da7b650238716ecca2037710c0296d7453193b24 - tested and working well (initial IP address appears as 0.0.0.0).