OpenELEC / unofficial-addons

OpenELEC unofficial addons
79 stars 125 forks source link

Bug in w_scan addon when use -I option (specify initial file) with DVB-T2 #157

Open DrummerKH opened 8 years ago

DrummerKH commented 8 years ago

Hi, w_scan addon have a bug in the code. When using initial file for specify own frequencies for DVB-T2 like this:

T2 545000000 8MHz AUTO AUTO AUTO AUTO AUTO AUTO AUTO 0

It shows error:

QAM_AUTO f = 0 kHz I999B8C999D999T999G999Y999P128 (0:0:0): skipped: (freq 0 unsupported by driver)

w_scan thinks that i specified 0Mhz, but its not true. I dig in the source code and find the error in the file parse-dvbscan.c on the block 231..248:

 case SCAN_TERRESTRIAL:

                            tn->delsys = SYS_DVBT;
                            arg = terr_frequency;
                            if (strlen(token) >= 2)
                                    if (token[1] == '2') {
                                            flags->need_2g_fe = 1;
                                            tn->delsys = SYS_DVBT2;
                                            arg = terr_plp_id;
                                            }
                            tn->inversion = INVERSION_AUTO;
                            tn->bandwidth = 8000000;
                            tn->coderate = FEC_AUTO;
                            tn->coderate_LP = FEC_NONE;
                            tn->modulation = QAM_AUTO;
                            tn->transmission = TRANSMISSION_MODE_AUTO;
                            tn->guard = GUARD_INTERVAL_AUTO;
                            tn->hierarchy = HIERARCHY_AUTO;
                            break;

Here in case of DVB-T system arg variable was set properly to terr_frequency and frequency will be got from the initial file. But in case DVB-T2 system arg variable rewriting to the terr_plp_id value, and frequency will not be get never from the file. If i`m right can you solve it ASAP please. I need scan DVB-T2 not ordinary frequency, but cant for now. Also i can solve the bug in code but dont know how compile the binary for the OpenElec.