OpenELEC / unofficial-addons

OpenELEC unofficial addons
80 stars 125 forks source link

adding package streamdisc-server #88

Closed tilwolff closed 8 years ago

tilwolff commented 8 years ago

streamdisc-server is a new addon in the section service/multimedia.

use it to watch a dvd or blu ray on your raspberry, wetek play or any other device without optical drive while the physical disc is in the optical drive of your main openelec pc .

lrusak commented 8 years ago

Looks pretty good :+1:

You should split the libs into separate packages. Just put them into the lib directory. libdvdcss libdvdread

Also, I see you are the owner of the streamdisc repo, so you should create releases on there and have the PKG_VERSION follow that.

You also need PKG_MAINTAINER=

tilwolff commented 8 years ago

Thanks, will do.

I was not aware it was possible to separate addons into several packages. Just realized I could just have used "get_build_dir libdvdread" in the "addon()" function and use the default build instructions for the packages.

On 11/27/15 21:07, Lukas Rusak wrote:

Looks pretty good :+1:

You should split the libs into separate packages. Just put them into the lib directory. libdvdcss libdvdread

Also, I see you are the owner of the streamdisc repo, so you should create releases on there and have the PKG_VERSION follow that.

— Reply to this email directly or view it on GitHub https://github.com/OpenELEC/unofficial-addons/pull/88#issuecomment-160198857.


tilman wolff-siemssen kopischstr. 3 10965 berlin

fon +49 179 900 1074

tilwolff commented 8 years ago

done. what do I put into PKG_MAINTAINER??

chewitt commented 8 years ago

@tilwolff - It should be a method for contacting you, e.g. email address, url to a contact form, or an OE or Kodi forum nick. Use mild obfuscation if you want/need to, e.g. user (at ) domain (dot) tld

chewitt commented 8 years ago

looks good to me - @lrusak any final objections?

lrusak commented 8 years ago

@tilwolff can you squash the commits into one commit per package please? Then I can merge.

tilwolff commented 8 years ago

all commits squashed into one...

lrusak commented 8 years ago

just a couple final fixups with the versioning and it should be good to go.

tilwolff commented 8 years ago

fixed up versioning and squashed again

lrusak commented 8 years ago

Thanks for your contribution :)