search

OpenEMS / openems

OpenEMS - Open Source Energy Management System
GNU Affero General Public License v3.0
818 stars 403 forks source link

fix: Delete the duplicate button #2844

Closed Jasonlee6789 closed 1 month ago

Jasonlee6789 commented 1 month ago

ion-segment itself already manages a group of buttons (ion-segment-button elements). By removing the redundant wrapper, it could simplify the DOM structure, making code cleaner.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2844 +/- ## ============================================= + Coverage 56.01% 56.41% +0.40% - Complexity 8197 8673 +476 ============================================= Files 2103 2147 +44 Lines 89017 90682 +1665 Branches 6560 6746 +186 ============================================= + Hits 49853 51148 +1295 - Misses 37446 37709 +263 - Partials 1718 1825 +107 ```
sfeilmeier commented 1 month ago

Thank you! Could you please fix/adjust the new indentation also?

sfeilmeier commented 1 month ago

Thank you!