OpenEPaperLink / Home_Assistant_Integration

Home assistant Integration for the OpenEPaperLink project
Apache License 2.0
137 stars 32 forks source link

Image positioned incorrectly with drawcustom and rotated image. #50

Closed psfales closed 9 months ago

psfales commented 9 months ago

When using drawcustom and "rotate: 180" the last line of the screen (or the first line, depending on how you look at it) is not written and maintains whatever was there from the previous image:

Steps to reproduce the behavior:

  1. Put an image on the screen where the last is a known color (e.g. white)
  2. Call drawcustom where the image is created with "rotate: 180" and last line is a contrasting color (e.g. black)
  3. Note that the last line is still the old color (e.g. white)

The new image should go all the way to the bottom of the screen, but it apparently stops one line short. This does not happen with "rotate: 0"

I've attached a couple of photos to help demonstrate the problem. The image with the two colored squares is displayed first and is an uploaded .jpg file. The image displayed next is the one with the text and is created with drawcustom.

Note that the tag is mounted "upside down" so the "last" line is at the top, and the text is rotated 180 degrees.

tagB tagA

psfales commented 9 months ago

For what it's worth, I realized that I can't reproduce this on my Solum E-ink tag. I only see it on the "Yellow AP" with the 320x172 TFT display.

jonasniesner commented 9 months ago

I have no idea how this could happen on the epaper since it has no context of the last image. Is this a new issue or did it only appear after an update?

psfales commented 9 months ago

Since the problem doesn't seem to happen with epaper, it's not a big deal. Go ahead and close the issue.l