OpenESignForms / openesignforms

Open eSignForms is the first open source SaaS web contracting platform
https://open.esignforms.com
107 stars 50 forks source link

� character in DbSetup suspected of causing encoding issues #163

Closed IQuant closed 8 years ago

IQuant commented 8 years ago

DbSetup.java v16.1.16

Found 19 occurrences of Unicode Replacement Character (U+FFFD) suspected of causing issues during installation.
ie. Ansi Enoding renders '�' symbol

Lines 629 - 630 String[] moneyOptions = { "123456789.12","�123,456,789","�123,456,789.12","�123,456,789","�123,456,789.12"}; String[] moneyValues = { "##############0.00","'�'###,###,###,###,##0","'�'###,###,###,###,##0.00","'�'###,###,###,###,##0","'�'###,###,###,###,##0.00"};

Line 3792 ddvo.setOption("�LAND ISLANDS");

Lines 5958 - 5059 "'�' - Fixed pound sign\n" + "'�' - Fixed euro sign\n" +

Lines 5097 - 5110

    ddvo.setOption("�123,456,789");
        ddvo.setValue("'�'###,###,###,###,##0");
        optionList.add(ddvo);
        ddvo = DropDownVersionOption.Manager.createNew(ddv, order++);
        ddvo.setOption("�123,456,789.12");
        ddvo.setValue("'�'###,###,###,###,##0.00");
        optionList.add(ddvo);
        ddvo = DropDownVersionOption.Manager.createNew(ddv, order++);
        ddvo.setOption("�123,456,789");
        ddvo.setValue("'�'###,###,###,###,##0");
        optionList.add(ddvo);
        ddvo = DropDownVersionOption.Manager.createNew(ddv, order++);
        ddvo.setOption("�123,456,789.12");
        ddvo.setValue("'�'###,###,###,###,##0.00");

http://goo.gl/7hnVfg

57 Compiling Errors:

DbSetup.java:5110: error: unmappable character for encoding ASCII

OpenESignForms commented 8 years ago

Don't understand. We have no compile errors in our code, and Java (Unicode) and our system in general use UTF8 for all character encoding and no other encoding is supported. The "broken" symbol you see I suspect is the EURO symbol.

OpenESignForms commented 8 years ago

Interesting...unsure when this went bad. The euro and pound currency symbols do seem corrupted in the code, resulting in those values being wrong in the drop down as well.

OpenESignForms commented 8 years ago

This has been corrected in the DbSetup.java and will be included in the 16.2.13 release. For those who installed when it was not working and need the correct values, please update the following drop downs in your ESF/Library/Template:

ESF_Countries - update second entry option -> value to be: Åland Islands -> AX

ESF_MoneyFormat - update entries 8-11 option -> value to be: £123,456,789 -> '£'###,###,###,###,##0 £123,456,789.12 -> '£'###,###,###,###,##0.00 €123,456,789 -> '€'###,###,###,###,##0 €123,456,789.12 -> '€'###,###,###,###,##0.00