search

OpenESignForms / vaadin-ckeditor

Vaadin component wrapper around CKEditor
4 stars 11 forks source link

Fix setVisible() behaviour with multiple editors #59

Closed jpikl closed 7 years ago

jpikl commented 7 years ago

Fixes #36

OpenESignForms commented 7 years ago

This is tricky as I'm not much of a GIT user, but I think this was pulled in. I'll have to see what it means to subsequently get it all into the VAADIN7 branch as that was created from the master a bit ago to get prepared for Vaadin 8. Then again, we may not get to Vaadin 8 anytime soon, so maybe it's fine we're still using the master branch.

OpenESignForms commented 7 years ago

We will have to investigate a bit, but the update is making for strange behavior in our app that uses the editor. Something is amiss, causing it to show the editor improperly resized, etc. I'm guessing it's the "reconnecting" nature that is somehow not quite as it ought to be.

In fact, you can see it in the demo app if you open subwindow 100% height. That is no longer working. So there's some additional initialization of the editor that is needed for it being loaded/unloaded. Perhaps it's not correctly triggering the 'onInstanceReady' and so all of the setup is not taking place again.

It's a bit odd because we don't even use the setVisible() option in our code.