OpenElements / hedera-enterprise

Module for Spring that adds support to communicate with the Hedera network
Apache License 2.0
3 stars 4 forks source link

Add constructor tests for FileCreateRequest #4

Open hendrikebbers opened 1 month ago

hendrikebbers commented 1 month ago

πŸ†•πŸ₯ First Timers Only

This issue is reserved for people who have never contributed to hedera-enterprise or any open source project in general. We know that creating a pull request (PR) is a major barrier for new contributors. The goal of this issue and all other issues labeled by 'good first issue' is to help you make your first contribution to Hedera.

πŸ‘Ύ Description of the issue

In the hedera-base module you can find the ProtocolLayerDataCreationTests test class. The class use junit to automatically test the construction of all records that are used in the protocol layer (see com.openelements.hedera.base.protocol package). As you can see the class tests provides (by using Assertions.assertDoesNotThrow) and negative (by using Assertions.assertThrows) checks for the creatation of records. Today not all records are fully tested and tests for the record FileCreateRequest are missing.

Suggested solution

Create a new test method in the ProtocolLayerDataCreationTests class that is named by the given pattern of all other test methods and implement the needed tests for the record.

πŸ“‹ Step by step guide to do a contribution

If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. A more detailed general documentation of the GitHub PR workflow can be found here.

πŸŽ‰ Contribute to Hacktoberfest

Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽

πŸ€” Additional informantion

If you have any questions, just ask us directly in this issue by adding a comment. You can join the Hedera community chat at Discord. A general manual about open-source contributions can be found here.

Ariho-Seth commented 20 hours ago

Hello!, i would like to work on this issue, may you please assign it to me?