Closed hendrikebbers closed 1 week ago
Hi, I'm interested in this one, please add me as assignee.
Hi there, can you assign this to me please!
please checkout the PR. Do I need to start PR in the hedera-enterprise repo?? Pls tell
no, that is not needed :)
pr is merged. Thank you for the contribution @megha-66
🆕🐥 First Timers Only
This issue is reserved for people who have never contributed to hedera-enterprise or any open source project in general. We know that creating a pull request (PR) is a major barrier for new contributors. The goal of this issue and all other issues labeled by 'good first issue' is to help you make your first contribution to Hedera.
👾 Description of the issue
Today, we support the
installMirrorNode
input parameter to start a Mirror Node instance and make it available atlocalhost:8080
. For custom GitHub Runners or Actions, port 8080 may not be used. Therefore, it is important to make the port configurable.Suggested solution
Provide an additional (optional) input parameter
mirroNodePort
that defines the port that should be used (default is still8080
). The defined port will than be used to forward the internal Mirror Node port (seekubectl port-forward
command). Since the port is now configurable we need to add the used port as an output. Here we suggest to define 2 new outputs:mirroNodePort
: This output param contains only the port (like8080
).mirrorNodeUrl
: This output param defines the mirrorNode URL (likehttp://localhost:8080
).📋 Step by step guide to do a contribution
If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. A more detailed general documentation of the GitHub PR workflow can be found here.
🎉 Contribute to Hacktoberfest
Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽
🤔 Additional informantion
If you have any questions, just ask us directly in this issue by adding a comment. You can join the Hedera community chat at Discord. A general manual about open-source contributions can be found here.