OpenElements / hedera-solo-action

A GitHub Action for setting up a Hedera Solo network
Apache License 2.0
0 stars 4 forks source link

Update to new solo version #5

Open hendrikebbers opened 1 month ago

hendrikebbers commented 1 month ago

🆕🐥 First Timers Only

This issue is reserved for people who have never contributed to this project or any open source project in general. We know that creating a pull request (PR) is a major barrier for new contributors. The goal of this issue and all other issues labeled by 'good first issue' is to help you make your first contribution.

👾 Description of the issue

This Github Action use the Hedera solo cli interally. You repo of solo can can be found here: https://github.com/hashgraph/solo

When creating this issue v0.31.0 is the latest release of solo: https://github.com/hashgraph/solo/releases/tag/v0.31.0 Currently the action uses solo v0.28.1. We need to update the solo version that is used in the action to the newest version. Sadly just changing the version number is not successfull since this will end in a broken GitHub Action. I assume that the CLI commands of solo has changed a little between v0.28.1 and v0.31.0. Documentation about the usage of solo can be found in the readme of the project.

Suggested solution

Update the internally used version of solo to the latest release and refactor the usage of solo in the Github Action so that the action works as expected.

📋 Step by step guide to do a contribution

If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. A more detailed general documentation of the GitHub PR workflow can be found here.

🎉 Contribute to Hacktoberfest

Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽

🤔 Additional informantion

If you have any questions, just ask us directly in this issue by adding a comment. You can join the Hedera community chat at Discord. A general manual about open-source contributions can be found here.

omsuneri commented 1 month ago

@hendrikebbers please assign me this issue i ll work on it

Phransis commented 4 weeks ago

I'm interested

Ndacyayisenga-droid commented 6 days ago

@Phransis @omsuneri is any of you still interested in this issue?

Phransis commented 5 days ago

I'm interested

On Thu, 14 Nov 2024 at 04:47, Tayebwa Noah @.***> wrote:

@Phransis https://github.com/Phransis @omsuneri https://github.com/omsuneri is any of you still interested in this issue?

— Reply to this email directly, view it on GitHub https://github.com/OpenElements/hedera-solo-action/issues/5#issuecomment-2475407964, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATIXPFDHRZ7IADIYDGRVLJ32AQTP7AVCNFSM6AAAAABPF3YP4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZVGQYDOOJWGQ . You are receiving this because you were mentioned.Message ID: @.***>

Phransis commented 5 days ago

Got it, thanks!

On Thu, 14 Nov 2024 at 19:32, Tayebwa Noah @.***> wrote:

Assigned #5 https://github.com/OpenElements/hedera-solo-action/issues/5 to @Phransis https://github.com/Phransis.

— Reply to this email directly, view it on GitHub https://github.com/OpenElements/hedera-solo-action/issues/5#event-15303490858, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATIXPFEL7BJEQMNBHLOFZXL2AT3DFAVCNFSM6AAAAABPF3YP4SVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGMYDGNBZGA4DKOA . You are receiving this because you were assigned.Message ID: @.*** com>