search

OpenEmu / FCEU-Core

OpenEmu Core plugin with FCEUX to support NES emulation
11 stars 10 forks source link

zlib version #3

Open anthonator opened 10 years ago

anthonator commented 10 years ago

What version of zlib is preferred for FCEU-Core? I've tried 1.2.8 and it seems too new. Compiling throws the following errors:

src-fceumm/file.c:171:20: error: member reference base type 'void' is not a structure or union
  for(tmp->size=0; gzgetc(tz) != EOF; tmp->size++);
                   ^~~~~~~~~~
./utils/zlib/zlib.h:1682:15: note: expanded from macro 'gzgetc'
          ((g)->have ? ((g)->have--, (g)->pos++, *((g)->next)++) : gzgetc(g))
           ~~~^ ~~~~

When you look at gzgetc it doesn't seem to like passing void as an option since 1.2.4.

I'd be happy to submit PR's to support new versions of zlib if that would be helpful.

anthonator commented 10 years ago

Switching to zlib 1.2.3 does fix the issue.

mrvacbob commented 10 years ago

The system zlib. If it's reading local copies of zlib (or headers) instead of the system ones they should be deleted.