OpenEnergyDashboard / OED

Open Energy Dashboard (OED)

Mozilla Public License 2.0

75 stars 263 forks source link

restructure: Export Redux store from separate file #1059

Closed hyperupcall closed 10 months ago

hyperupcall commented 11 months ago

Description

Defining the Redux store in the same file as the app will create problems with Vite. There is some issue with circular imports not working properly with HMR (hot module replacement). Upstream tracks this issue at vitejs/vite#3033; a workaround is to define and export the Redux store from a different file. This commit does exactly that to circumvent the circular import issue.

Related to #879

Type of change

[ ] Note merging this changes the database configuration.
[ ] This change requires a documentation update

Checklist

[x] I have followed the OED pull request ideas
[x] I have removed text in ( ) from the issue request
[x] You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

N/A

huss commented 10 months ago

Thanks to @hyperupcall for the quick response. Everything looks goos and this is ready to merge.