OpenEnergyDashboard / OED

Open Energy Dashboard (OED)
Mozilla Public License 2.0
82 stars 307 forks source link

Delete units #1065

Closed sparakala21 closed 8 months ago

sparakala21 commented 1 year ago

Description

I added the handleDelete function in EditUnitModalComponent.tsx so that admins can delete units when it is necessary. I also added a way to ensure safety when an admin changes a meters intrinsic properties. (Please include a summary of the change and which issue is touched on. Please also include relevant motivation and context.)

Fixes #1020 and Fixes #1042.

Type of change

Checklist

Limitations

huss commented 10 months ago

@sparakala21 I could not easily separate out the changes I had tried so I decided to push then out to the PR. There are some comments about open items. Feel free to change my code as needed and to address the items left. Let me know if I can help and thanks for looking into this.

huss commented 8 months ago

I just wanted to document that this PR is waiting on PR #1113 since it changes how Redux state is accessed. After that, this work will be updated and all concerns addressed.

huss commented 8 months ago

I updated the PR to merge in #1113 and edited so uses the Redux Toolkit. I also made all the other needed changes to it works as desired. It should be ready to merge.