OpenEnergyDashboard / OED

Open Energy Dashboard (OED)
Mozilla Public License 2.0
82 stars 307 forks source link

Remove remnants of react-notification-system #1069

Closed spearec closed 1 year ago

spearec commented 1 year ago

Description

As part of the work in migrating to React 18, we switched from react-notification-system to the newer react-toastify. Some remnants of the old package were not removed. I should have removed all references, but if there's anything I have missed feel free to add a commit to this PR to remove them.

Due to this old package, we were building OED's dependencies with --legacy-peer-deps. This is no longer required, so I have regenerated package-lock.json using npm i. This should optimize the dependency tree for a regular install.

It also seems that the package-lock had a version tag of 0.8.0, so the regeneration updated that as well.

Fixes #1000

Type of change

Checklist

huss commented 1 year ago

Thanks @spearec for doing this. I had a question. package-lock.json has a lot of changes and more than I would expect from just removing the one package. Was a full install done? Did you want to include all these changes in this PR? I want to be sure it does what is intended and it is noted.

spearec commented 1 year ago

Yes, I deleted the package-lock and recreated it with npm i. This is because, to my understanding, building with the legacy peer deps flag can create a different package lock tree. I can do some more research to make sure.

huss commented 1 year ago

I looked over the package changes and they are mostly minor updates. I planned to begin package upgrades soon so this seems fine. Modest testing found no issues so I think these changes are fine. We also have lots of time to see if any small issues are found.

spearec commented 1 year ago

Yeah, the only things that changed from the package lock would be peer dependencies, so there shouldn't be any issues.