Closed alexis0705 closed 10 months ago
Hi @huss , thanks for your advise! I have changed my code.
Hello, I included the following line at the beginning of readingsBarMeterQuantity.js: const Unit = require('../../models/Unit');
During the GitHub test run, I faced a syntax error, highlighting, "SyntaxError: Identifier 'unit' has already been declared." Interestingly, on my local machine, the removal of this line triggers a "ReferenceError: Unit is not defined."
I'm uncertain about whether to retain or remove this line.
Hello, I included the following line at the beginning of readingsBarMeterQuantity.js: const Unit = require('../../models/Unit');
During the GitHub test run, I faced a syntax error, highlighting, "SyntaxError: Identifier 'unit' has already been declared." Interestingly, on my local machine, the removal of this line triggers a "ReferenceError: Unit is not defined."
I'm uncertain about whether to retain or remove this line.
@alexis0705 I believe the issue is that a recent merge into development added the same include but it was in a slightly different place in the file. I merged the latest development into your PR. It works fine locally and when I push it out to GitHub to your PR it now passes all tests. I'll try to get to the formal review of your changes soon.
Review of the code found it is all good and running found it works correctly. Congratulations to @alexis0705 on their first accepted contribution.
Thanks to Mustafa Evgin Demirci and John Mikko Velasquez for their support and collaboration. Looking forward to more great teamwork!
Awesome work guys!
It was a beneficial experience all around. Thank you guys for being my team partners!
Description
I worked on test case B8 with the description: "1 day bars for 15 minute reading intervals and quantity units with +-inf start/end time & kWh as MJ"
Partly Addresses #962 .
Type of change
(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])
Checklist
(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)
Limitations
None.