search

OpenEnergyDashboard / OED

Open Energy Dashboard (OED)
Mozilla Public License 2.0
75 stars 263 forks source link

B12 Implementation #1091

Closed ThatCodebyTony closed 9 months ago

ThatCodebyTony commented 10 months ago

Co-authored-by: Jugraj Pandher pjugraj@yahoo.com Co-authored-by: Katrina Huynh katrinabth@gmail.com Co-authored-by: Arthur Nguyen arthurnnguyen@gmail.com

Type of change

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

Limitations

(Describe any issues that remain or work that should still be done.)

huss commented 10 months ago

@ThatCodebyTony Could you verify if Katrina Huynh is Ngoc Vu Bao Huynh with GitHub ID ngocvbh. I'm trying to match to people who have agreed to the CLA.

ThatCodebyTony commented 10 months ago

@ThatCodebyTony Could you verify if Katrina Huynh is Ngoc Vu Bao Huynh with GitHub ID ngocvbh. I'm trying to match to people who have agreed to the CLA.

Katrina Huynh said she is now submitting the CLA. Her GitHub ID is : https://github.com/huynhkatrina

huss commented 9 months ago

@ThatCodebyTony, @huynhkatrina & @jugpan I wanted to check in on the status of this PR. Could you let me know if changes are planned and any thoughts on the review provided?

ThatCodebyTony commented 9 months ago

@ThatCodebyTony, @huynhkatrina & @jugpan I wanted to check in on the status of this PR. Could you let me know if changes are planned and any thoughts on the review provided?

Thanks for reminding us. We have made the necessary changes to the code.

huss commented 9 months ago

Thanks to @ThatCodebyTony, @huynhkatrina & @jugpan for making all the requested changes. Everything looks good and this is ready to merge. Congratulations on your first accepted contribution to OED.