Closed ngocvbh closed 9 months ago
Hello @huss, thank you for reviewing our contribution! I just want to make sure I understand your change request correctly, do I revert the changes I made to the expected file?
Hello @huss, thank you for reviewing our contribution! I just want to make sure I understand your change request correctly, do I revert the changes I made to the expected file?
@ngocvbh Since the values I see before the PR were wrong (there was an issue with the values that the new expected file has fixed), I'm not sure reverting your changes will work. You can copy the version from Design Docs to replace the one you have so they are the same. That should work. If you prefer, I can make the change but wanted to give you the opportunity. If this is not clear then please let me know.
@huss Thank you for your clarification! I have updated the expected file to match with the one in Design Docs.
Description
Implemented test L20 with description: "should have daily points for 15 minute reading intervals and quantity units with +-inf start/end time & kWh as lbs of CO2 & chained & reversed."
Co-authored By: @aaronlhh, @SirKentut, and @ObtuseGooose.
Partly Addresses #962.
Type of change
Checklist