OpenEnergyDashboard / OED

Open Energy Dashboard (OED)
Mozilla Public License 2.0
75 stars 263 forks source link

Should groups allow raw meter data #1105

Open huss opened 9 months ago

huss commented 9 months ago

Is your feature request related to a problem? Please describe.

OED forbids raw meter data in any graphic that sums data so it is currently only allowed in line/3D graphics. The rationale is that summing raw data does not make sense. The canonical example is temperature where no use case for summing the values is known. Further, flow meter data has the same database code so a site can use that instead of raw to do summing. For example, summing a rate/flow data such as gallon/hour does have use cases such as getting the total rate into a building.

A group can be constructed from any compatible meters where groups are a set of meters. Currently, a group can be formed from raw units. Since groups are an aggregation, they have similarities to graphics that do aggregation where they allow for summing on line/3D graphics too. Thus, there seems to be an inconsistency with raw data where groups allow aggregation and graphics do not.

Describe the solution you'd like

There seem to be three ways to go:

  1. Change groups to disallow raw data in groups. This would be a new limitation but there are no known situations where this will cause an issue. In the unlikely event that a site has this already, the migration would warn them of the change.
  2. Continue to allow groups to do raw data. Admins can be warned that it is not usual so it would hopefully not be used much. This is somewhat inconsistent with OED's philosophy where it tries to put up guard rails against bad usage. Note if we do choice 1 then OED could relax in the future to this choice if use cases come forward.
  3. Allow all graphics to do raw data. Since this would be available to general users for any raw meter data this could lead to incorrect use. Since the same functionality is available via flow, this is viewed as likely the least desirable.

This issue is designed to seek input/thoughts from others to make the best choice since once it is done OED hopes not to change it. At the current time, the first choice of disallowing raw meters in groups would be the way OED would go.

Describe alternatives you've considered

Unless someone comes up with a rationale to keep the current situation or another alternative, there are no known alternatives at this time.

Additional context

It would be good to decide this before OED 1.1 (or the next release) so any change is done as soon as possible. This means deciding soon (in the coming weeks) would be desirable.