OpenEnergyDashboard / OED

Open Energy Dashboard (OED)
Mozilla Public License 2.0
75 stars 263 forks source link

test B5 #1108

Closed kaito1105 closed 8 months ago

kaito1105 commented 8 months ago

Description

Co-authored by: @SebastianRamos3, and @avery-belmont

Partly Addresses #962

Type of change

Checklist

huss commented 8 months ago

@kaito1105 Thank you for you contribution to OED. Please follow the directions for a PR. If nothing else, please check the box indicating every contributor has signed the CLA and the names are listed in the description. Please let me know if you have any questions or concerns.

huss commented 8 months ago

I have three questions about CLA agreements:

  1. @kaito1105 created the PR
  2. @avery-belmont is listed as contributing to the PR in the description
  3. Maryam Bouamama is listed as contributing to the commit

In each case I cannot find a record of these people agreeing to the OED CLA. Given the record, it appears each of these people need to sign the CLA. If I have missed something in the record of CLA agreements or you have any thoughts then please let me know. Otherwise, OED needs the CLA agreements before this work can be accepted.

avery-belmont commented 8 months ago

May you please send me the CLA agreement? Also, @avery-belmont is me, Maryam Bouamama. Thank you!

On Tue, Jan 9, 2024 at 12:35 PM Steven Huss-Lederman < @.***> wrote:

I have three questions about CLA agreements:

  1. @kaito1105 https://github.com/kaito1105 created the PR
  2. @avery-belmont https://github.com/avery-belmont is listed as contributing to the PR in the description
  3. Maryam Bouamama is listed as contributing to the commit

In each case I cannot find a record of these people agreeing to the OED CLA. Given the record, it appears each of these people need to sign the CLA. If I have missed something in the record of CLA agreements or you have any thoughts then please let me know. Otherwise, OED needs the CLA agreements before this work can be accepted.

— Reply to this email directly, view it on GitHub https://github.com/OpenEnergyDashboard/OED/pull/1108#issuecomment-1883581544, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCHMA253E66UOP3U3AIIRLYNWEWJAVCNFSM6AAAAABBPFUDLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBTGU4DCNJUGQ . You are receiving this because you were mentioned.Message ID: @.***>

huss commented 8 months ago

@avery-belmont For the CLA, please see https://openenergydashboard.github.io/developer/cla.html.

avery-belmont commented 8 months ago

Completed!

On Tue, Jan 9, 2024 at 1:02 PM Steven Huss-Lederman < @.***> wrote:

@avery-belmont https://github.com/avery-belmont For the CLA, please see https://openenergydashboard.github.io/developer/cla.html.

— Reply to this email directly, view it on GitHub https://github.com/OpenEnergyDashboard/OED/pull/1108#issuecomment-1883618232, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCHMA3EDXIH4JSNOFTTOYTYNWH4ZAVCNFSM6AAAAABBPFUDLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBTGYYTQMRTGI . You are receiving this because you were mentioned.Message ID: @.***>

huss commented 8 months ago

Thanks to @kaito1105, @SebastianRamos3 & @avery-belmont for their first contribution to OED. Review found the code is fine and it runs as desired. This PR will be ready to merge once the CLA question with @kaito1105 is resolved.