huss
commented
9 months ago I just pushed changes to this PR. They do the final removal for the unit index from code and DB. It also merged in development to be sure there are no issues. I noted in the description that this changes the DB configuration and announced on Discord. With @qnhn22 changes and these, this PR is hopefully ready to merge. This completes the design doc steps until "Integrating cik".
Description
I have created a new state called 'Cik' for client-side usage. The code has been refactored to eliminate the need for the 'pik' array, replacing it with the newly introduced 'Cik' state. In order to make 'Cik' accessible, I have developed a new API that fetches 'Cik' data, which includes updating the model, creating an SQL file for retrieving information from the database, and implementing a new route.
Additionally, since the 'pik' is no longer required, the unit index can be removed from the unit table and refactor the code to eliminate any usage of the unit index. (database changed)
Fixes #901
(In general, OED likes to have at least one issue associated with each pull request. Replace [issue] with the OED GitHub issue number. In the preview you will see an issue description if you hover over that number. You can create one yourself before doing this pull request. This is where details are normally given on what is being addressed. Note you should not use the word "Fixes" if it does not completely address the issue since the issue would automatically be closed on merging the pull request. In that case use "Partly Addresses #[issue].)
Type of change
(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])
Checklist
(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)
Limitations
(Describe any issues that remain or work that should still be done.)