OpenEnergyDashboard / OED

Open Energy Dashboard (OED)

Mozilla Public License 2.0

75 stars 263 forks source link

Implementing Test B5 #1111

Closed HanCotterell closed 8 months ago

HanCotterell commented 8 months ago

Description

Implemented test B5 as per instructions, "75 day bars for 15 minute reading intervals and quantity units with +-inf start/end time & kWh as kWh".

Partially addresses #962

Type of change

[ ] Note merging this changes the database configuration.
[ ] This change requires a documentation update

Checklist

[x] I have followed the OED pull request ideas
[x] I have removed text in ( ) from the issue request
[x] You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

huss commented 8 months ago

I want to thank @HanCotterell for the work in implementing test B5. Unfortunately there was some confusion about who was supposed to be working on this test. After consulting with CodeDay, the decision was made to use the work in PR #1108 that is now merged into OED. As a result, OED will not be able to merge this PR and it needs to be closed.

Having said this, I did review the code and it seems correct and does what was desired. As such, it is of the same quality as other code merged into OED.