OpenEnergyDashboard / OED

Open Energy Dashboard (OED)
Mozilla Public License 2.0
75 stars 263 forks source link

Max/min parsing function #1128

Closed alfarj83 closed 7 months ago

alfarj83 commented 7 months ago

Added function to parse min/max values in the data.

With the new function, the line reading tests should no longer ignore the minimum and maximum values of the data.

Partly addresses #984 by adding needed test code.

Type of change: T-enhancement

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

Will need to test if the function works by replacing the old line tests.

huss commented 7 months ago

Thanks to @alfarj83 for this pull request. A few thoughts:

Once these are resolved, I will do a careful read/test of the code. Let me know if you have any questions.

huss commented 7 months ago

I just made a very small change to the mocha description so line with min/max is different. I should have told you to do that so I just did it.