OpenEnergyDashboard / OED

Open Energy Dashboard (OED)
Mozilla Public License 2.0
75 stars 263 forks source link

Added test LG7 #1130

Closed RoyVanVu closed 7 months ago

RoyVanVu commented 7 months ago

Description

Creating test LG7 from the design document in collaboration with https://github.com/VivianBelle17 and https://github.com/Vizsla1 Partly Addresses: #962

Type of change

Checklist

Limitations

First time use docker and find a way to go through all of the files

huss commented 7 months ago

Thanks to @RoyVanVu for this contribution. I don't see a record that you signed the CLA. Assuming this is correct, please use the link in the description/Checklist to do this. If you think my records are wrong then please let me know. Also, there are often teams working on the tests so if others contributed to this work then please let me know their GitHub IDs (often put in the pull request description) and get them to do the CLA. If not, just let me know you worked on this alone. Please let me know if I can help.

RoyVanVu commented 7 months ago

Hi @huss! I'm sorry for the issue. My team member has completed the CLA agreement, and her GitHub name is VivianBelle17 (https://github.com/VivianBelle17). I hope this will help; please don't hesitate to let me know if there are any other issues.

huss commented 7 months ago

@RoyVanVu I now see a CLA from everyone but you. If that is correct, could you please fill it out. Let me know if you have any thoughts/questions.

RoyVanVu commented 7 months ago

Hi @huss! I finish my CLA agreement

RoyVanVu commented 7 months ago

Hi @huss! I just uploaded the expected_line_group_ri_15-20_mu_kWh_gu_kWh_st_2022-08-20%07#25#35_et_2022-10-28%13#18#28.csv and deleted the line of the comment above LG7 as you said

huss commented 7 months ago

The changes look good. Congratulations to @RoyVanVu, @VivianBelle17 & @Vizsla1 on their first merged contribution.