OpenEnergyDashboard / OED

Open Energy Dashboard (OED)

Mozilla Public License 2.0

75 stars 263 forks source link

Added LG20 test #1134

Closed GaryZLG closed 7 months ago

GaryZLG commented 7 months ago

Description

Implemented test case LG20 with description: "should have daily points for 15 + 20 minute reading intervals and quantity units with +-inf start/end time & kWh as lbs of CO2 & chained & reversed" Uploaded its appropriate CSV expected values file.

Co-authored by: @stephanienguyen2020

Partly Addresses #962

Type of change

[ ] Note merging this changes the database configuration.
[ ] This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

[x] I have followed the OED pull request ideas
[x] I have removed text in ( ) from the issue request
[x] You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

huss commented 7 months ago

Thanks to @GaryZLG for their first pull request. I don't see a CLA by @stephanienguyen2020. Could they please do it by using the link in the Description/Checklist above. If you think my records are off then please let me know.

stephanienguyen2020 commented 7 months ago

Thanks to @GaryZLG for their first pull request. I don't see a CLA by @stephanienguyen2020. Could they please do it by using the link in the Description/Checklist above. If you think my records are off then please let me know.

@huss Hi Steven, I just did. Can you please check?

huss commented 7 months ago

Thanks to @GaryZLG for their first pull request. I don't see a CLA by @stephanienguyen2020. Could they please do it by using the link in the Description/Checklist above. If you think my records are off then please let me know.

@huss Hi Steven, I just did. Can you please check?

@stephanienguyen2020 Looks good. I have it. Thanks.

GaryZLG commented 7 months ago

Thanks to @GaryZLG & @stephanienguyen2020 for their first contribution to OED. Overall this looks good. I made one comment to resolve.

Hi @huss , thanks for the changes requested for our code. I have replied to the reviewed conversation with my issue and my thoughts. I'm not familiar with the interface of Pull Request, so I'm not sure if I should click "Resolve Conversation". Could you please check my issue in the conversation replay and update with us for more information?

huss commented 7 months ago

Thanks to @GaryZLG & @stephanienguyen2020 for their first contribution to OED. Overall this looks good. I made one comment to resolve.

Hi @huss , thanks for the changes requested for our code. I have replied to the reviewed conversation with my issue and my thoughts. I'm not familiar with the interface of Pull Request, so I'm not sure if I should click "Resolve Conversation". Could you please check my issue in the conversation replay and update with us for more information?

No problem. I added a comment and resolved.