OpenEnergyDashboard / OED

Open Energy Dashboard (OED)

Mozilla Public License 2.0

75 stars 263 forks source link

Add compare tests #1153

Closed alfarj83 closed 5 months ago

alfarj83 commented 6 months ago

Description

Added functions to parse and test the compare meter data.

Type of change

Test data implementation

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

[ ] Note merging this changes the database configuration.
[X] This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

[X] I have followed the OED pull request ideas
[X] I have removed text in ( ) from the issue request
[X] You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

The function is still a work in progress (i.e. not completely able to run), and for now the test case just has values hardcoded into it.

huss commented 5 months ago

Thanks to @alfarj83 for addressing all the comments. This works as expected and is ready to merge. Note I will update the testing design doc to reflect this and add more desired compare tests (hopefully) in the near future.