search

OpenEnergyDashboard / OED

Open Energy Dashboard (OED)
Mozilla Public License 2.0
73 stars 252 forks source link

convert admin maps page to modals #1197

Open huss opened 2 months ago

huss commented 2 months ago

Is your feature request related to a problem? Please describe.

The admin maps page does not conform to the new modal look in OED.

Describe the solution you'd like

The look of this page will change substantially to align with the new modal card look in OED. The top of the page will have a create button that takes the admin to the page to create a map that uses the current pages. Note this is actually a sequence of pages. A card for each map will have the map name, map display & note (30 characters max as on current modal pages) listed along with a button to edit the map.

When the edit button is clicked, a modal pops up that shows all the values on the current page except the id that will not be shown. The admin can modify any of them except the last modify date that is set by the software. The actions taken on a change will be similar to the current page but the look should be consistent with the new modal pages. For example, the button to delete the map is similar to the conversion page.

Note the current page allows for editing multiple maps but that will not be allowed on the new page. Only one map at a time to be consistent with other modal pages. The change to the modal setup may change a number of the functions and state interactions.

Given what is done when a map is created/calibrated, it is unclear if that should be a modal as we want it to be the full size of the page. At some point, it should be checked to see if changing it would make sense.

Describe alternatives you've considered

Leave as is

Additional context

This replaces issue #891 since the hooks was replaced with issue #1145 and the modal part is here.

ChrisMart21 commented 2 weeks ago

@huss is this issue still reserved? I'm currently working on many of the admin pages maps included. This rework changes how admin pages update edits locally using redux state. The pages will also share a modal across all admin pages. It seems that some of the work I'm doing overlaps with this issue. This is a screen cap of what I've got going so far image

huss commented 2 weeks ago

@ChrisMart21 There is a team working on the admin and CSV pages. If you are already working on admin map then that is fine. If they have more time they can address other issues. Do you want me to assign you this issue?

Also, are your updates to edit Redux state just for maps or will it impact all admin pages? If so, will they likely cause conflicts with the team working on some of the pages?

ChrisMart21 commented 2 weeks ago

@huss Unfortunately I've touched all admin pages quite a bit. I'm unsure if this will cause issues for the other teams, but definitely changes it quite a bit. I don't want to step on any toes, or interfere with other teams... could we sync up to discuss this?

huss commented 2 weeks ago

@ChrisMart21 Okay. I think it will be okay. We can talk privately about this.