search

OpenEnergyDashboard / OED

Open Energy Dashboard (OED)
Mozilla Public License 2.0
83 stars 316 forks source link

CSS: centralize styles, combine, limit usage #1203

Open huss opened 7 months ago

huss commented 7 months ago

Is your feature request related to a problem? Please describe.

There is a modest amount of CSS styling done on pages. Doing it in a consistent way is desired.

Describe the solution you'd like

The following would be used for CSS:

  1. When the same styling is used in multiple places then it is defined in one place and reused. For example, formInputStyle is defined in multiple places.
  2. There are similar but slightly different styles in places. Decide if it really is necessary to do this.
  3. Some styles may have minimal effect. As a rule, OED should only custom CSS when really needed.

A careful sweep of the code to final all CSS styles will be needed to decide which ones can be modified.

Describe alternatives you've considered

Leave as is

Additional context

None

danielshid commented 4 months ago

I will be working on this issue.

williamw04 commented 3 months ago

I can work on this issue

huss commented 3 months ago

@danielshid Are you working on this or is it okay for @williamw04 to do this issue? Thanks.

vladoleksiyenko commented 1 week ago

Hi, is this issue by any chance open? My team has been eyeing it as a potential issue to pick up. Please let me know, but don't assign it right away, as we'd like to discuss other issues. Thank you.

huss commented 1 week ago

Hi, is this issue by any chance open? My team has been eyeing it as a potential issue to pick up. Please let me know, but don't assign it right away, as we'd like to discuss other issues. Thank you.

This issue is assigned and I believe that developer is actively working on the issue. @williamw04 can confirm.