OpenEnergyDashboard / OED

Open Energy Dashboard (OED)
Mozilla Public License 2.0
75 stars 263 forks source link

Inserting Test Data without File Read and Write #1233

Closed kramosss closed 4 months ago

kramosss commented 4 months ago

Description

Avoids reading and writing to a file for test data and instead directly inserts the test data into the data base.

Partly Addresses #141 and #1131

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

Limitations

The test data still has some issue running in parallel and will need to be worked on in the future.

huss commented 4 months ago

I made changes to deal with async code, get test cases to work and other items. I tried to update all PR comments so they are in sync with these changes and resolved as appropriate. Some comments are marked outdated due to shifting line so @kramosss let me know if it is unclear what they apply to.

kramosss commented 4 months ago

I updated the code and it should have all the changes, feel free to let me know if I missed something or if there are any other changes to be made.

huss commented 4 months ago

Thanks to @kramosss for the quick update. Everything looks good. Congratulations on another accepted contribution to OED.