OpenEnergyDashboard / OED

Open Energy Dashboard (OED)
Mozilla Public License 2.0
83 stars 316 forks source link

Standardize Translation Method #1354

Closed lawsj closed 1 month ago

lawsj commented 1 month ago

Description

Made changes to use the new "useTranslate()" instead of the old "translate()".

Partly Addresses #1204

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

Limitations

N/a

Rakesh-Ranga-Buram commented 1 month ago

Everything looks good to me. Please convert the draft to PR.

Rakesh-Ranga-Buram commented 1 month ago

@huss , this PR only include changes related to translate() method and not formatMessage() method. Since formatMessage() changes are already been done on #1314

huss commented 1 month ago

This is just for the record: We are continuing to try to determine the cause of the issue. It may well be something outside the direct changes made in this PR.

Rakesh-Ranga-Buram commented 1 month ago

@huss , the code has been updated with the discussed changes. Can you please review this PR

huss commented 1 month ago

I pushed commits to do the following:

  1. Merge in development and address conflicts.
  2. Added missing CSV menu translations. Not directly related to this PR but similar so did it.
  3. Removed a couple of uses of useTranslate from maps because outside function component and causing issues.