OpenEnergyDashboard / OED

Open Energy Dashboard (OED)
Mozilla Public License 2.0
83 stars 316 forks source link

Adding base for the client side Max&Min default values on create unit… #1364

Closed mmehta2669 closed 4 weeks ago

mmehta2669 commented 1 month ago

… issue

Description

This pr adds the max min default values to CreateUnitModalComponent.tsx as well as making minor changes units.tx and Unit.js to add the new parameters

Partly Addresses #1307

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

Limitations

This pr only does the base client side, it still requires the server side connection as well as the prefer display changes to fully address the create unit part of the problem

huss commented 4 weeks ago

This is to note that I have discussed the PR with the developer. @mmehta2669 is working with a team to address issues #1307. They have decided to close the draft PRs, work to create a single, comprehensive version and then submit a new PR. As such, this PR is desired to be closed and I am doing this.