search

OpenEnergyDashboard / OED

Open Energy Dashboard (OED)
Mozilla Public License 2.0
83 stars 315 forks source link

Completed test case C15 #1375

Closed developersbm closed 3 weeks ago

developersbm commented 3 weeks ago

Implemented test C15 in readingsCompareMeterFlow.js

Co-authored by: Sebastian Bastida Marin: @developersbm Aliyah McDowell: @amcdowell226 Colin Nguyen: @khoamelo

Partly Addresses #962

Type of change Implemented test for C15 (Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

[ ] Note merging this changes the database configuration. [ ] This change requires a documentation update

Checklist (Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

[x] I have followed the OED pull request ideas [x] I have removed text in ( ) from the issue request [x] You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations The implemented test doesn't work with C15's expected values [1990.55774277443, 2057.611897078], but works with the expected values [7962.23097109771, 8230.447588312], which is the expected value for C2.

huss commented 3 weeks ago

I merged in the updated SQL (merged development) and updated the expected values to the new ones in the testing design doc. They all work now. I also needed to update the expected value for CG15 due to the value being wrong in the testing design document. CG15 is not really part of this PR put the tests were failing so I included this fix in this PR. See the developer Discord channel for a discussion of the issue.