OpenEnergyDashboard / OED

Open Energy Dashboard (OED)
Mozilla Public License 2.0
83 stars 315 forks source link

Custom rate and named standard rate for units (Issue #1216) #1387

Closed gyordong closed 6 days ago

gyordong commented 1 week ago

Description

This PR adds a custom rate box for unit creation and edit.

Fixes #1216

Type of change

Checklist

Limitations

huss commented 1 week ago

@gyordong I started to review this PR and found changes that don't seem related to the work done. I looked into this and found that previously merged changes seem to be gone in several files. One example is processData.js (line 787-8). Did you have merge conflicts when you brought in development? I see a commit with the msg "fixing mrge" on 11/15/24 but did not easily determine that is where the change happened. The bottom line is I'm nervous about these changes and what may now be out of sync with development. I think this needs to be resolved carefully (and let me know if you think I am wrong about this). If we should discuss more then please let me know.