Open huss opened 3 years ago
PR #598 did the dropdown menu. The issue of it exceeding the allowed area is still there.
Pushed back to 1.0 since critical issue of map choice was fixed in PR #598.
Many of the items are scaling as expected. It appears that the ones above and below the graphic on the right side of the page do not scale correctly as show by (gotten by shrinking the horizontal size):
where the type and language menus are above/below the the graph area. This is probably okay but would be nice to clean up and might relate to issue #466 about graphics not scaling nicely.
The click areas to choose the days for bar graphics do not wrap/scale as other items. While not related to French, it is easier to see as the name is longer (gotten by shrinking the horizontal size):
Another little glitch was when the horizontal size was made larger it messed up by bringing the menu below up:
This self corrected when the horizontal size was tweaked.
Another issue is on the compare graphic. The text rotated to be on the diagonal when the bar labels are longer but the one on the right can get cut off as show in this figure:
Issue #611 is another example of this.
PR #1113 changed the page layout. Overall, some of these issues are resolved or better. However, the issue of the time selection on bar/compare/map is still there.
Ideally, a general solution to sizing would be found.
PR #1173 helps with long text that was not translated but is not a general solution.
This may need to become a separate issue but OED is not perfect with different screen sizes and then it is narrow (such as a cell phone). A general solution should be sought.
As we have expanded what OED can do, we are having issues with the layout of the page. For example, the new map choice means the options often go beyond the area set aside. Maybe making this a drop-down would be the correct fix. We should make sure the docked menus do similar things. (Fixed by PR #598)
On a related item, when we change languages (see French as an example) the translated text can exceed the area reserved for the text. We should see if there is a general way to fix this.