OpenEnergyPlatform / academy

The Open Energy Academy is a collection of courses, tutorials, and questions for the Open Energy Family
https://openenergyplatform.github.io/academy/
GNU Affero General Public License v3.0
16 stars 6 forks source link

Metadata 1.4 Release #57

Closed christian-rli closed 5 years ago

christian-rli commented 5 years ago

In order to finalize metadata version 1.4, we still need to address a few things. I changed the examples according to our discussion last week. A list of things that we have to finally agree on:

Feel free to add issues to this list, in case I forgot them.

Once we've agreed on everything we can merge the 1.4 branch into master and declare it the final version 1.4. (By the way, I'd argue against calling it version 1.4.1, because I believe it will lead to more confusion down the road than necessary, especially when there is no real version 1.4).

christian-rli commented 5 years ago

I pushed my commits for this issue into a new branch v1.4_release. Latest change is this one: https://github.com/OpenEnergyPlatform/examples/commit/1d035d2db86f820906690efd5b86c2347e19b37e

christian-rli commented 5 years ago

Our template file is not consistent - neither within itself nor with our own requirements. Most values are "", but not all are. Some are "null" and some have actual strings. Why is that and shouldn't it be consistently "null", except for the fields we actually do require?

christian-rli commented 5 years ago

Have a look at this file. If there are no complaints it will end up defining the structure of metadata version 1.4. @MGlauer let me know if you agree to @Ludee 's comments in #55

MGlauer commented 5 years ago

There is also my remark from #54. It should not be "null" but null.

Explanation: There have to be clear semantics for "Nothingness". At the moment it would be possible to have "null" and null in the same documents. Are they equal? What happens if I name my dataset "null" ;P

christian-rli commented 5 years ago

closed with #58