search

OpenEnergyPlatform / data-preprocessing

Repository for data formatting, import of data, data and metadata review, and data curation.
GNU Affero General Public License v3.0
10 stars 7 forks source link

review/SzenarienDB_conversion_text #29

Closed han-f closed 4 years ago

han-f commented 5 years ago

We have uploaded the two tables related to units/metrics and conversion to model_draft and submit them to the review process

Metadata and data for review:

  1. SzenDB_meta_units
  2. SzenDB_meta_conversion

Reviewed and published metadata and data:

  1. szenariendb_units
  2. szenariendb_conversion
christian-rli commented 4 years ago

I made a few small changes to the strings. Everything seems plausible. Do you have a preferred schema where the tables should be moved to?

han-f commented 4 years ago

Thanks @christian-rli . @l-emele had a few further suggestions on how to improve the tables themselves. This may result in changes of the metadata, too. How do you think we should best proceed with this? Keep tables in model_draft, overwrite them there and resubmit metadata (if it did change)? If yes, then we could keep this ticket open until we know whether the metadata has changed and react accordingly once we know?

christian-rli commented 4 years ago

I'd suggest just keeping this issue open @han-f . You can change the tables in model_draft and let me know here when you're done. Then there is no need to resubmit the metadata :)

If there are any relevant changes, you/I can make the necessary updates to the metadata (just commit your changes and reference this issue) and I can upload them afterwards.

wingechr commented 4 years ago

files have been updated. please review.

l-emele commented 4 years ago

For clarification: We not only update the metadata but also the table structure and the data on the OEP.

l-emele commented 4 years ago

Unfortunately this review is now pending for almost three months. Could someone please review?

stap-m commented 4 years ago

Why don't we use PRs for the review?

l-emele commented 4 years ago

So far this was the process...

jh-RLI commented 4 years ago

We use PRs to merge fully reviewed metadata into the develop branch. But I suggest to always create a new branch and PR. The issue should then be linked to the PR. We are currently reworking this process the result will be documented in our wiki.

Ludee commented 4 years ago

Review of metadata and move of data finished!