Closed wingechr closed 3 years ago
I made a few changes. It looks like you started with an older version of the metadata string (since the licences under the sources key were missing some subkeys), but it should be good now. The file can be parsed with omi as is. If you don't object to any of the changes @wingechr , I would end the review :)
Danke @christian-rli - looks ok so far, but I see you made changes to the original license. It now reads in the subfields CC BY 4.0, whereas on the eionet website it is published as CC BY 2.5 DK (https://creativecommons.org/licenses/by/2.5/dk/deed.en_GB).
Thanks for checking @han-f ! You're right. I just saw the CC logo and thought I knew what was going on. I fixed the spdx identifiers and titles and it should be fine now. With no further comments I'd end the review.
I have checked the data on how it is displayed on the OEP now.The original license is not rendered in the metadata display. Under "Sources" field "Licenses" it reads: There is no valid entry for this field Is there a way to fix this post the move to target schema? It should indicate CC BY 2.5 DK. https://creativecommons.org/licenses/by/2.5/dk/deed.en_GB
sources/0/licenses
How can we add it to the metadata now that it is already in its target schema?
I realised we can change metadata in the target schema via the interface. I made the correction and amended the metadata accordingly.
Issue description
Workflow checklist