search

OpenEnergyPlatform / data-preprocessing

Repository for data formatting, import of data, data and metadata review, and data curation.
GNU Affero General Public License v3.0
10 stars 7 forks source link

Review: CAMS Timeseries #65

Closed christian-rli closed 3 years ago

christian-rli commented 3 years ago

Issue description

I'm submitting an OEMetadata string for review. Please see review_process.md for technical detail.

The dataset is not under an open license. The data provide time series of Global, Direct, and Diffuse Irradiations on horizontal surface, and Direct Irradiation on normal plane (DNI) for the actual weather conditions as well as for clear-sky conditions (source).

Workflow checklist

  1. GitHub

    • [x] I have submitted this issue to have metadata review documented (Issue #NR)
    • [x] Create a new review-branch and push OEMetadata to new branch (review/project_nameofdata#NR)

  2. OEP

    • ! The corresponding data is not open and won't be uploaded to the OEP

  3. Start a Review

    • [x] Start a pull request (PR) from review-branch to master
    • [x] Assign a reviewer and get in contact

  4. Reviewer section

    • [x] A reviewer starts working on the issue
    • [x] Review data license
    • [x] A reviewer finished working on this issue (and awarded a badge)
    • [x] Merge PR and delete review-branch
    • [x] Document final links of metadata in issue description
    • [x] Close issue

Metadata and data for review

Here are the links to my data and metadata. Naming follows the pattern model_draft.project_nameofdata: Metadata: https://github.com/OpenEnergyPlatform/data-preprocessing/blob/review/project_nameofdata/data-review/project_nameofdata.json Data: https://openenergy-platform.org/dataedit/view/model_draft/project_nameofdata

Reviewed and published metadata and data

Final naming and location of the metadata after the review are as follows:

christian-rli commented 3 years ago

I deleted several key-value pairs, because they do not appear in the metadata standard. Please note that arbitrary new keys to the metadata string are not supported as of yet. I left a note in the wiki to discuss this. Specifically the keys and values were:

under spatial: "latitude": "36.8299", "typeLatitude":"positive North, ISO 19115", "longitude": "-2.4054", "typeLongitude": "positive East, ISO 19115"

under temporal: "timeReference": "Universal Time (UT)"

note: ISO 8601 does not seem to allow for times specified in UT / UT1. The information is quite relevant, however. We should discuss this for the next metadata version, so I added another note to the wiki

christian-rli commented 3 years ago

@fradra I created this isse for the review of your CAMS timeseries metadata file and made the changes listed above. If you have any comments on this, please leave them in this issue.

christian-rli commented 3 years ago

From what I can tell, the string is valid now, although omi seems to be unable to parse it. I filed an issue to solve this.