search

OpenEnergyPlatform / data-preprocessing

Repository for data formatting, import of data, data and metadata review, and data curation.
GNU Affero General Public License v3.0
10 stars 7 forks source link

Review: Technology data generation wind turbine #92

Open steull opened 2 years ago

steull commented 2 years ago

Issue description

I'm submitting an open dataset with a corresponding OEMetadata string for review.

Workflow checklist

  1. GitHub

    • [x] I have submitted this issue to have metadata and data review documented (Issue #93 )
    • [x] Create a new review-branch and push OEMetadata to new branch (review/project_nameofdata#NR). If this step is too difficult, attach a file with the metadata as a comment in this issue and let the reviewer know.

  2. OEP

    • [x] Upload data to the OEP in schema model_draft (see upload tutorial)
    • [x] Link URL of data in this issue (model_draft.project_nameofdata)

  3. Start a Review

    • [x] Start a pull request (PR) from review-branch to master
    • [x] Assign a reviewer and get in contact

  4. Reviewer section

    • [x] A reviewer starts working on the issue
    • [x] Review data license
    • [x] A reviewer finished working on this issue (and awarded a badge)
    • [x] Update metadata on table
    • [ ] Data moved to its final schema
    • [ ] Add OEP tags to table
    • [ ] Merge PR and delete review-branch
    • [ ] Document final links of metadata and data in issue description
    • [ ] Close issue

Metadata and data for review

Here are the links to my data and metadata. Naming follows the pattern model_draft.project_nameofdata: Metadata:

Data: https://openenergy-platform.org/dataedit/view/model_draft/rli_dea_td_generation_wind_turbine

Reviewed and published metadata and data

Final naming and location of the data and metadata after the review are as follows: schema.tablename

chrwm commented 2 years ago

Hi, @steull thanks for starting the review process. Unfortunately, the links to data and metadata seem corrupted. Please fix them.

Ludee commented 2 years ago

Fixed the metadata link but the data is not uploaded yet.

steull commented 2 years ago

Data are uploaded on the OEP. Link is attached.

jh-RLI commented 2 years ago

@steull please also grant permissions to table. You can add the RLI user group. Use the red permissions button next to the table view on the OEP :)

steull commented 2 years ago

Thank you for this hint. I added RLI user group as admin.

chrwm commented 2 years ago

Thanks for the fix. I'm not sure whether "wind_turbine" needs to be in every column name, but besides that, the data description looks fine. Did we also want to demonstrate the ontology within the metadata? In this case, the "is_about" field needs to be filled out.

steull commented 2 years ago

Linked the wrong pull request which closed the issue.