search

OpenEnergyPlatform / oekg

Repository for the Open Energy Knowledge Graph (OEKG)
Creative Commons Zero v1.0 Universal
8 stars 0 forks source link

[SFS] Cannot delete contact person for factsheet #20

Closed han-f closed 9 months ago

han-f commented 1 year ago

Description of the issue

I added a contact person for the factsheet which is incorrect, but I can not delete it, I can only edit it (equal to giving the same instance a new label I think).

Ideas of solution

Add a delete from field button in the edit field, to remove a wrong contact person from the field "who is the contact person for this factsheet" , but not delete the contact person as such.

Workflow checklist

christian-rli commented 1 year ago

I can confirm this issue. It is also possible to add the same person several times in this way and to add names to the dataset that are not added in the drop down list. It's unclear to me what is merely a label and what is actually instantiated.

christian-rli commented 1 year ago

I found out, that the contact can be deleted. When the mouse hovers over the input field a ✕ symbol appears and that deletes the input. Such a symbol in the field below may be more intuitive. It's remains true that a contact cannot be deleted from the selection list.

han-f commented 1 year ago

I tried it and this works. But it deletes all entries that were made. I think we need to have a functionality where we can delete individual entries from the input field.

adelmemariani commented 1 year ago

We can use checkboxes in the dropdowns to add entities to OEKG or remove entities from factsheets (but not the OEKG). Currently, only editing is possible via factsheets. Removing entities from OEKG is somehow risky, and we postponed the decision about entity removal to the future. Basically, we should decide who can remove from OEKG and via which interface.

stap-m commented 9 months ago

I think this is also solved. Access control is in progress.