search

OpenEnergyPlatform / oemetadata

Repository for the Open Energy Family metadata. Contains metadata templates, examples and schemas. For metadata conversion see https://github.com/OpenEnergyPlatform/omi
https://openenergyplatform.github.io/oemetadata/
MIT License
21 stars 3 forks source link

Add tests to prevent duplicated schema entries. #125

Open jh-RLI opened 1 year ago

jh-RLI commented 1 year ago

Thank you for finding all the redundancies and little errors! Maybe it's possible to write a test for duplicates in future.

Originally posted by @christian-rli in https://github.com/OpenEnergyPlatform/oemetadata/issues/117#issuecomment-1467709172

jh-RLI commented 1 year ago

@christian-rli can you tell me a bit more about the test you suggested. As far as I understand, the test would look for duplicate entries in schmea.json?

christian-rli commented 1 year ago

There isn't more to tell. You just described the suggested test in its entirety :)

jh-RLI commented 1 year ago

Ah okay, just any duplocate (like key names). I thought you had an example as I didn't follow the discussion before :)

christian-rli commented 1 year ago

I looked into the commits again. the naming suggested duplicate ("redundant") fields. I seems like there weren't actually any, but it's a useful test to be implemented anyway (and an easy one, in case someone needs to learn how to write tests).