Collection of bugs in v1.5.1

OpenEnergyPlatform / oemetadata

Repository for the Open Energy Family metadata. Contains metadata templates, examples and schemas. For metadata conversion see https://github.com/OpenEnergyPlatform/omi

https://openenergyplatform.github.io/oemetadata/

MIT License

21 stars 3 forks source link

Collection of bugs in v1.5.1 #83

Open jh-RLI opened 2 years ago

jh-RLI commented 2 years ago

[ ] template: "metadataVersion": "OEP-1.5.0", -> "metadataVersion": "oemetadata_v1.5.1", The template.json still points to version v1.5.0. Generally we should think about how to fill these fields automatically, e.g. via a config file. This error occurs almost with each realease again.
[ ] example: "value": "onshore ", -> "value": "onshore",
[ ] example: "value": "offshore ", -> "value": "onshore", There are trailing spaces in the values.
[ ] metadata_key_description: 5 | language -> Add link to standard (https://tools.ietf.org/search/bcp47)

Ludee commented 2 years ago

Thanks for spotting this error. Can we hotfix this or do we need to create a v1.5.2?

jh-RLI commented 2 years ago

We could create a version v1.5.11 but we cant include this in v1.5.1 because it is not possible to override existing versions on pypi (pip)

Ludee commented 2 years ago

I just spotted some more minor bugs in the example and key_description. Let's use this issue to collect them for the next version.

Ludee commented 2 years ago

We just realised that the resource column needs the information if it is nullable or not. This is already implemented in the Upload Wizard but not included in the metadata.