OpenEnergyPlatform / oeplatform

Repository for the code of the Open Energy Platform (OEP) website. The OEP provides an interface to the Open Energy Family
http://openenergyplatform.org/
GNU Affero General Public License v3.0
61 stars 19 forks source link

[models] View does not update when editing a model and selecting a tag like "Openness" #1403

Closed maurerle closed 11 months ago

maurerle commented 11 months ago

Description of the issue

When editing a model, the general Information tab stays visible, even when clicking one of the other tabs. The selected tab is rendered below, which is more than one screen view below, so it feels like nothing happens at all.

This is very bad, as it is quite unintuitive that nothing happens. When adding a new model, it works as expected.

image

Steps to Reproduce

  1. Edit a model
  2. Click one of the Tabs like "Openness"
  3. View does not change, looks like nothing happened, but view is actually rendered below

Ideas of solution

Either set the focus to the section which should be edited (scroll down the view on click of the tags)

or remove the general information tab when a different one is selected (this is the current behavior when adding a new model)

Context and Environment

Website

Workflow checklist

jh-RLI commented 11 months ago

I also noticed this bug for me it also appears when i view a factsheet after i submitted a change. After like 20-40 seconds clicking on the tabs everything works again. Quite strange ... not error output at all.

There are a lot of bugs in the factsheet-pages code as we have no resources to properly maintain the code. This is a pity and i hope we can dedicate more resources to this by next year.

@christian-rli Reworking / Fixing the lagacy factsheet pages seems like an urgent tasks after we complete the main tasks by 04/2024 ... then update the metadata to version 2.0.0 and possibly update the model&framework factsheet pages after.

jh-RLI commented 11 months ago

Reagrding the described bug i also noticed that the view is actually updating but the first tab stays open and the content of the clicked tab is appended to the end of the page. That is unexpected.

jh-RLI commented 11 months ago

Fixed in #1407 and will be available with the next oep release (latest in the next two months, but probably much sooner :) )

han-f commented 11 months ago

I was able to get this to work, but realised that the moment I add information to a further area, the previously input information seems gone, even after refreshing. I guess we will wait a bit until we add further model information. In view of the scenario bundle factsheet it would be great to get this to work, as we will then be able to link the models to the bundle factsheets.

The ENUSEM model was already included in the model factsheets, but it does not seem to be in the OEKG, and I was not able to add this to one of our scenario bundle factsheets. This may be related to #1414

cc @l-emele