OpenEnergyPlatform / oeplatform

Repository for the code of the Open Energy Platform (OEP) website. The OEP provides an interface to the Open Energy Family
http://openenergyplatform.org/
GNU Affero General Public License v3.0
61 stars 19 forks source link

Styling of scenario bundles detail view #1435

Closed bmlancien closed 8 months ago

bmlancien commented 8 months ago

Summary of the discussion

Started styling of scenario bundles detail view

Type of change (CHANGELOG.md)

Added

Workflow checklist

Automation

Is part of #1282 #1283 #1284

PR-Assignee

Reviewer

jh-RLI commented 8 months ago

@bmlancien I resolved a conflict in the changelog. You can pull the changes, i had to merge develope into your branch :)

bmlancien commented 8 months ago

Done @jh-RLI :)

bmlancien commented 8 months ago

Hi @jh-RLI, I think you can now have a look at the PR. I tried to reorganize parts of the code. This can definitely be improved still. There are things I wanted to do but was not able to:

Responsiveness could also be improved on smaller screens. But maybe this is ok for now?

jh-RLI commented 8 months ago

Looks great :) Thanks you!

I think the icons and scrollbars can be added later.

The only thing i noticed is this small thing: If this is hard to fix i will just merge the PR now and we can fix this later :)

on openenergyplatform.org image

in this branch image

jh-RLI commented 8 months ago

FYI @adelmemariani I merge this branch now

bmlancien commented 8 months ago

Hey @jh-RLI, on my side this working properly. Maybe a problem with the cache? The view and edit buttons should look like that:

chrome-capture-2023-9-30

jh-RLI commented 8 months ago

You are correct, some changes have not been there due to some git issue. ItΒ΄s now visible to me ;)