OpenEnergyPlatform / oeplatform

Repository for the code of the Open Energy Platform (OEP) website. The OEP provides an interface to the Open Energy Family
http://openenergyplatform.org/
GNU Affero General Public License v3.0
61 stars 19 forks source link

Hotfix v0.16.3 #1490

Closed adelmemariani closed 6 months ago

adelmemariani commented 6 months ago

Summary of the discussion

Describe the findings of the discussion in the issue or meeting.

Type of change (CHANGELOG.md)

Added

Updated

Removed

Workflow checklist

Automation

Closes #1488 Closes #1489 Closes #1487

Part of #1478

PR-Assignee

Reviewer

jh-RLI commented 6 months ago

Hey @adelmemariani I have to be annoying about the branch again. This is not a HotFix as it doesn't merge directly into the master branch and also introduces new features.

I think you wanted to use the HotFix branch because you think it's easier for you because you only have to create one branch :D If that's the case and you're having trouble creating multiple branches, then you can also create a normal feature branch and reference any issues you implement. HotFix branches only serve a specific use case.

If it's not too much trouble, please rename the branch and create a new PR :) Thank you!

i suggest a branch name like feature-1488-1489-1487-enhance-scenario-bundle-functionality. (not sure if this fixes #1478 also if it is you can include it in the list)

jh-RLI commented 6 months ago

You can use Git to rename the branch, but GitHub will require you to create a new PullRequest because it can't recognize what the previous branch name was.

adelmemariani commented 6 months ago

Hey @adelmemariani I have to be annoying about the branch again. This is not a HotFix as it doesn't merge directly into the master branch and also introduces new features.

I think you wanted to use the HotFix branch because you think it's easier for you because you only have to create one branch :D If that's the case and you're having trouble creating multiple branches, then you can also create a normal feature branch and reference any issues you implement. HotFix branches only serve a specific use case.

If it's not too much trouble, please rename the branch and create a new PR :) Thank you!

i suggest a branch name like feature-1488-1489-1487-enhance-scenario-bundle-functionality. (not sure if this fixes #1478 also if it is you can include it in the list)

Thanks @jh-RLI . I got it. Please see this PR

jh-RLI commented 6 months ago

Thanks alot @adelmemariani. I will close this PR