OpenEnergyPlatform / oeplatform

Repository for the code of the Open Energy Platform (OEP) website. The OEP provides an interface to the Open Energy Family
http://openenergyplatform.org/
GNU Affero General Public License v3.0
61 stars 19 forks source link

add NFDI4Energy to partners #1605

Closed SMutyala18 closed 4 months ago

SMutyala18 commented 4 months ago

Summary of the discussion

Added NFDI4Energy to the partners section with a redirect link to the NFDI4Energy website

Type of change (CHANGELOG.md)

Added

Workflow checklist

Automation

Part of #1591

PR-Assignee

Reviewer

jh-RLI commented 4 months ago

@SMutyala18 can you merge the latest oeplatform:develop into your branch. Then the CI-Tests will pass.

jh-RLI commented 4 months ago

Ah, great, I assume it was renamed by you to install the oeplatform? Thanks for fixing some other issues along the way too.

SMutyala18 commented 4 months ago

Ah, great, I assume it was renamed by you to install the oeplatform? Thanks for fixing some other issues along the way too.

Yes, I had to rename the file while adding oeo.

SMutyala18 commented 4 months ago

The last thing missing is the changelog entry - Add NFDI to our list of Partners [(#1605)](https://github.com/OpenEnergyPlatform/oeplatform/pull/1605). You can add this to the file versions/changelogs/current.md in the section "Features".

I have updated the changelog file. Now, it should work.

jh-RLI commented 4 months ago

I will keep the corresponding issue open until the "Coming Soon" page is also implemented.

SMutyala18 commented 4 months ago

Yes, it (the CI) already worked after you corrected the name of the sec.settings :) The changelog entry is just a formal step. Great first contribution! I will merge the PR soon.

thanks :)