Feature 1675 profile tables titles

OpenEnergyPlatform / oeplatform

Repository for the code of the Open Energy Platform (OEP) website. The OEP provides an interface to the Open Energy Family

http://openenergyplatform.org/

GNU Affero General Public License v3.0

61 stars 19 forks source link

Feature 1675 profile tables titles #1706

Closed bmlancien closed 1 week ago

bmlancien commented 2 weeks ago

Summary of the discussion

The user cannot view the full table title on the profile/tables page

Type of change (CHANGELOG.md)

Changes

Change the profile tables by improving color contrast, splitting the tables in 2 rows on very large screens and making the whole title visible (https://github.com/OpenEnergyPlatform/oeplatform/pull/1706)

Features

Profile page Tables: Add "unpublish" button to published tables. (#1706)

Workflow checklist

Automation

Closes #1675 Closes #1702

In addition Closes #1542

PR-Assignee

[x] 🐙 Follow the workflow in CONTRIBUTING.md
[x] 📝 Update the CHANGELOG.md
[ ] 📙 Update the documentation on mkdocs

Reviewer

[x] 🐙 Follow the Reviewer Guidelines
[x] 🐙 Provided feedback and show sufficient appreciation for the work done

bmlancien commented 2 weeks ago

I added a placeholder of an empty state to the profile tables view. I would show it only if there is no table at all. If already one in draft or published then remove it.
I thought it could be a good idea to add a "add data set" button in that case. The JS function for that button is not working on that page, though. I didn't look any further.
Also added "Early Access" to the review tab. I simply used CSS for that as you mentioned one badge from Bootstrap didn't have rounded borders

bmlancien commented 2 weeks ago

Sorry @jh-RLI , I didn't realize it was not the right branch for #1702 (I should have created a new one) Is it okay to use this PR for fixing this too? These were small changes.

jh-RLI commented 2 weeks ago

It is okay to combine the changes. Sometimes it makes things more simple :) Just document the issues that are closed by this PR -> see the text "closes #1702" in your intial comment here.

bmlancien commented 1 week ago

Alright! And I didn't even know that moving the issue to "Done" would close it automatically...

jh-RLI commented 1 week ago

Sorry, I should have explained to you that Github has added this automation. I would suggest that you only move topics to the ‘In Progress’ column. Because once the PR is closed, these topics are also automatically closed by the keyword ‘Closes #ISSUENR’ you can find in the PR description under Workflow checklist.

bmlancien commented 1 week ago

Ah ok, good to know for next time! Learning by making mistakes...