OpenEnergyPlatform / omi

Repository for the Open Metadata Integration (OMI). For metadata definition see metadata repo:
https://github.com/OpenEnergyPlatform/metadata
GNU Affero General Public License v3.0
7 stars 4 forks source link

Fix get-dialect import issue #11

Closed 4lm closed 5 years ago

4lm commented 5 years ago

Hi all,

a commit two weeks ago removed an import of get_dialect: https://github.com/OpenEnergyPlatform/omi/commit/2e3fb99bb29be615420fb13bd78c9e006eff92b4#diff-49f99fb7574a1c4dace5a6bed846ee35L3

This resulted in an error when I tried to use omi from cli:

cli.py", line 19, in <module>
from omi.dialects import get_dialect
ImportError: cannot import name 'get_dialect'

After readding the specific import line, omi works again!

@MGlauer, @Ludee or @christian-rli, please review this pull request and merge it, if your review conclusion is positive! Thx!

4lm commented 5 years ago

The failed checks seem to be unrelated to my commit. Nevertheless, any ideas how to fix them? Maybe @Bachibouzouk knows?

MGlauer commented 5 years ago

The failed check is the style test for your code - more specifically an unstylish order of imports ;)

Just run isort and this test should work.

For good measure: Also run black and tox to put the continous integration gods in a gracious mood.

4lm commented 5 years ago

@MGlauer, thx for the hints! Will do!

codecov-io commented 5 years ago

Codecov Report

Merging #11 into dev will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #11      +/-   ##
==========================================
+ Coverage   80.23%   80.25%   +0.01%     
==========================================
  Files          31       31              
  Lines        1113     1114       +1     
  Branches      137      137              
==========================================
+ Hits          893      894       +1     
  Misses        188      188              
  Partials       32       32
Impacted Files Coverage Δ
src/omi/dialects/__init__.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cd6c99a...73f3b66. Read the comment docs.

4lm commented 5 years ago

All checks passed :rocket: