Closed 4lm closed 5 years ago
The failed checks seem to be unrelated to my commit. Nevertheless, any ideas how to fix them? Maybe @Bachibouzouk knows?
@MGlauer, thx for the hints! Will do!
Merging #11 into dev will increase coverage by
0.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## dev #11 +/- ##
==========================================
+ Coverage 80.23% 80.25% +0.01%
==========================================
Files 31 31
Lines 1113 1114 +1
Branches 137 137
==========================================
+ Hits 893 894 +1
Misses 188 188
Partials 32 32
Impacted Files | Coverage Δ | |
---|---|---|
src/omi/dialects/__init__.py | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update cd6c99a...73f3b66. Read the comment docs.
All checks passed :rocket:
Hi all,
a commit two weeks ago removed an import of get_dialect: https://github.com/OpenEnergyPlatform/omi/commit/2e3fb99bb29be615420fb13bd78c9e006eff92b4#diff-49f99fb7574a1c4dace5a6bed846ee35L3
This resulted in an error when I tried to use omi from cli:
After readding the specific import line, omi works again!
@MGlauer, @Ludee or @christian-rli, please review this pull request and merge it, if your review conclusion is positive! Thx!