search

OpenEnergyPlatform / omi

Repository for the Open Metadata Integration (OMI). For metadata definition see metadata repo:
https://github.com/OpenEnergyPlatform/metadata
GNU Affero General Public License v3.0
7 stars 4 forks source link

Features/oep v1 4 #14

Closed MGlauer closed 5 years ago

MGlauer commented 5 years ago

This PR enables OMI to use the final metadata version 1.4

MGlauer commented 5 years ago

It works! Just a nitpicky indentation comment:

  • "fields", "primaryKey" and "foreignKey" (within "resources") in the converted file need six more spaces of indentation

I think this is caused by your method @christian-rli ;P I just took the encode() function from the old code and put it into omi.dialects.oep.renderer. So I guess this bug is also present on the dev-branch. BTW: Is there a reason we do not use pprint?

christian-rli commented 5 years ago

The only reason we haven't been using pprint is that I haven't used/heard of it before. So it shall be implemented if deemed useful :)