search

OpenEnergyPlatform / omi

Repository for the Open Metadata Integration (OMI). For metadata definition see metadata repo:
https://github.com/OpenEnergyPlatform/metadata
GNU Affero General Public License v3.0
7 stars 4 forks source link

Release omi release v0.0.7#52 #53

Closed jh-RLI closed 2 years ago

nesnoj commented 2 years ago

Huh? I just installed 0.0.7 from PyPI but this branch has not even been merged? Also, there's no 0.0.7 listed in releases?

nesnoj commented 2 years ago

Another issue: I tried v0.0.7 from PyPI and omi translate -f oep-v1.4 meta.json throws

AttributeError: 'OEPMetadata' object has no attribute 'subject'

but in the definition of v1.4.1 there's no such field. Is has been introduced in v1.5. By the way, v0.0.6 runs successfully on the same file.

jh-RLI commented 2 years ago

Yes, I need to provide more documentation and had to release the omi package for the current OEP version. That's why I was hesitant to publish the new release "officialy". I should have merged this PR anyway sorry for the confusion :).

The exception is triggered because omi now supports both oem versions (v14, v15). I changed the default setting for the translate -t option of the CLI functionality to oep-v1.5. It should work with this command below. No one has really reviewed this yet, but omi for oem-v1.5 also runs on the OEP, so it's tested there.

omi translate -f oep-v1.4 -t oep-v1.4 meta.json

PS: I'm also working for the next release to improve the error messages and to add a metadata conversion function from 1.4 to 1.5. There is already a script developed by @chrwm here.

nesnoj commented 2 years ago

Thanks for tackling this so quickly @jh-RLI!